Repository navigation
ci(docker): Don't block merges on the image vulnerability scan - #165
Merged
Merged
Conversation
Co-Authored-By: Armen Zambrano Gasparnian <44410+armenzg@users.noreply.github.com>
armenzg
approved these changes
Nov 9, 2026
armenzg
marked this pull request as ready for review
November 9, 2026 13:54
armenzg
enabled auto-merge (squash)
November 9, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Grype scan ran inside
Docker build, whichRequired checksdepends on. So when a new CVE shows up in the base image, every PR fails, even ones that don't touch the image. That's happening now withzlib1ginpython:3.15.2-slim(see #164).This moves the scan into its own
Image vulnerability scanjob and leaves it out ofRequired checks. It still runs on every PR and push tomainand shows as a failed check, so findings stay visible, but they no longer block merges. The scan settings (only-fixed,severity-cutoff: high) are unchanged.The new job builds the image again, since jobs don't share a Docker daemon. It reads the layer cache that
Docker buildwrites, but doesn't write to it, so the two jobs don't race on the cache.Docker buildkeeps the build and the startup check.via @armenzg.
via @armenzg.
--
View Session [Sentry]